Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 51363 var_export outputs an E_WARNING when recursion is detected #146

Closed
wants to merge 1 commit into from

Conversation

lonnylot
Copy link

@lonnylot lonnylot commented Aug 5, 2012

The documentation for var_export state that it does not handle circular references. However, var_export does not catch recursion. It leaves it to the zend hash functions to catch recursion. In here a E_ERROR is thrown when the recursive limit is hit.

This patch changes the var_export to detect recursion and throw a E_WARNING. E_WARNING was chosen b/c it is documented that var_export does not handle recursion, but it does not say var_export will cause an E_ERROR. This also allows for user created error handlers to handle the situation.

@php-pulls
Copy link

Comment on behalf of stas at php.net:

duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants