fix missing error check in curl_multi_init() #13157
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unsure if it should return false (like curl_init()) or throw (like most constructors do on failure) though..
|
.. come to think of it, if it's a vote, I'm voting to throw |
nielsdos
reviewed
Jan 15, 2024
nielsdos
reviewed
Jan 15, 2024
ext/curl/multi.c
Outdated
|
|
||
| multi = curl_multi_init(); | ||
| if(UNEXPECTED(multi == NULL)) { | ||
| zend_throw_error(NULL, "Could not initialize a new cURL multi handle"); |
There was a problem hiding this comment.
Not sure if this should be an error or exception, looking at interface.c these kinds of failures throw an exception with a wording like "Failed to ..." (see interface.c)
Anyway, I'll let @adoy have the final say as he maintains ext/curl.
There was a problem hiding this comment.
made the error message more interface.c-like
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unsure if it should return false (like curl_init()) or throw (like most constructors do on failure) though..