getting SimpleXML doc namespaces #112
Merged
+140
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 21, 2012 22:34
Allows you to recursively check namespaces under a child node instead of from the root of the XML doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was recently emailed asking to have the patch for bug 55218 added in. I updated it and fixed a minor bug.
Currently if you recursively get an XML docs namespaces via SimpleXML::getDocNamespaces it will always start from the root regardless of what node you call the method from.
The patch allows you to recursively get the XML doc namespaces starting from the node you pass in.
We add in a second parameter to the SimpleXML::getDocNamespaces method called 'from_root'. This param defaults to 'true' to keep backwards compatibility. If set to 'false' then we only retrieve the namespace(s) for the node the method is called from.