Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ext/intl usmg_parse_helper possible mem leak fixes on failure path. #10830

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ext/intl usmg_parse_helper possible mem leak fixes on failure path. #10830

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Member

introducing an utility class which calls a lambda from its destructor when going out of scope.

Girgias
Girgias reviewed Mar 13, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose the cleanup_zvals() macro didn't handle this? In which case the Formattable::kString could be used to detect the memory leak potentially?

@devnexen
ext/intl usmg_parse_helper possible mem leak fixes on failure path.
3bd41f5 
introducing an utility class which calls a lambda from its destructor
when going out of scope.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias left review comments

Assignees
No one assigned
Labels
Extension: intl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devnexen @Girgias