ext/phar: changing few methods returning true to void ones. #10804
Conversation
devnexen
force-pushed
the
phar_stub_update
branch
3 times, most recently
from
4ca8287 to
8f78edd
Compare
devnexen
force-pushed
the
phar_stub_update
branch
from
8f78edd to
8e422d8
Compare
There was a problem hiding this comment.
Overall, these are risky changes. In case of IntlDateformatter::setTimeZone, the return type change made more sense, since the new return value is part of the return type. But in case of these phar methods, a completely different type is going to be returned. I don't think we should do this in a minor version, but I'd be ok to "deprecate" the true returns in PHP 8.3, and then make these methods void in PHP 9.0. I'm not sure about the best course of action though. E.g. we could use the RETURN_VALUE_USED macro to emit a deprecation notice. Unfortunately, this doesn't always work. :(
| @@ -112,7 +112,7 @@ public function buildFromIterator(Traversable $iterator, ?string $baseDirectory | |||
| public function compressFiles(int $compression): void {} | |||
|
|
|||
| /** @return bool */ | |||
| public function decompressFiles() {} // TODO make return type void | |||
| public function decompressFiles(): void {} | |||
There was a problem hiding this comment.
IMO these shouldn't be made native type declarations first so that the type declarations users already have can be fixed easier.
No description provided.