Skip to content

Fix incorrect short-circuiting in constant expressions #10030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

iluuu1994
Copy link
Member

@iluuu1994 iluuu1994 commented Dec 1, 2022

Fixes GH-10014

Sharing short_circuited in the context would work if we reset it at the end of zend_ast_evaluate_ex of every AST element that isn't part of the short-circuiting chain but since we have many exit-points that would be very error prone.

@iluuu1994 iluuu1994 merged commit 683d81e into php:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak during constant expression evaluation
1 participant