Skip to content

Prevent abstract in anonymous classes in compiler #16067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DanielEScherzer opened this issue Sep 25, 2024 · 1 comment
Closed

Prevent abstract in anonymous classes in compiler #16067

DanielEScherzer opened this issue Sep 25, 2024 · 1 comment
Labels
Feature Status: Needs Triage

Comments

@DanielEScherzer
Copy link
Member

Description

Based on discussion in #15995
DanielEScherzer added a commit to DanielEScherzer/php-src that referenced this issue Sep 25, 2024
@DanielEScherzer
phpGH-16067: test current output
4a20e09 
So that it is clear what changes
DanielEScherzer added a commit to DanielEScherzer/php-src that referenced this issue Sep 25, 2024
@DanielEScherzer
phpGH-16067: prevent abstract in methods of anonymous classes
f0a1d74 
As an extra benefit, the error message now points to the line of the method
rather than just the overall class declaration.
@DanielEScherzer DanielEScherzer mentioned this issue Sep 25, 2024
Merged
DanielEScherzer added a commit to DanielEScherzer/php-src that referenced this issue Sep 25, 2024
@DanielEScherzer
phpGH-16067: prevent abstract in methods of anonymous classes
2dcbfca 
As an extra benefit, the error message now points to the line of the method
rather than just the overall class declaration.
DanielEScherzer added a commit to DanielEScherzer/php-src that referenced this issue Sep 26, 2024
@DanielEScherzer
phpGH-16067: test current output
01ae6e9 
So that it is clear what changes
DanielEScherzer added a commit to DanielEScherzer/php-src that referenced this issue Sep 26, 2024
@DanielEScherzer
phpGH-16067: prevent invalid abstract during compilation of methods
c08b0ba 
For classes that are not declared `abstract`, produce a compiler error for any
`abstract` methods. For anonymous classes, since they cannot be made abstract,
the error message is slightly different.
DanielEScherzer added a commit to DanielEScherzer/php-src that referenced this issue Oct 18, 2024
@DanielEScherzer
phpGH-16067: test current output
1251d95 
So that it is clear what changes
DanielEScherzer added a commit to DanielEScherzer/php-src that referenced this issue Oct 18, 2024
@DanielEScherzer
phpGH-16067: prevent invalid abstract during compilation of methods
0f9c1a4 
For classes that are not declared `abstract`, produce a compiler error for any
`abstract` methods. For anonymous classes, since they cannot be made abstract,
the error message is slightly different.
iluuu1994 pushed a commit to DanielEScherzer/php-src that referenced this issue Oct 23, 2024
@DanielEScherzer @iluuu1994
phpGH-16067: test current output
2ee8794 
So that it is clear what changes
iluuu1994 pushed a commit to DanielEScherzer/php-src that referenced this issue Oct 23, 2024
@DanielEScherzer @iluuu1994
phpGH-16067: prevent invalid abstract during compilation of methods
de22d20 
For classes that are not declared `abstract`, produce a compiler error for any
`abstract` methods. For anonymous classes, since they cannot be made abstract,
the error message is slightly different.
iluuu1994 added a commit that referenced this issue Oct 23, 2024
@DanielEScherzer @iluuu1994
GH-16067: prevent invalid abstract during compilation of methods (G…
0b94cf6 
…H-16069)

For classes that are not declared `abstract`, produce a compiler error for any
`abstract` methods. For anonymous classes, since they cannot be made abstract,
the error message is slightly different.

Co-authored-by: Ilija Tovilo <ilija.tovilo@me.com>
@iluuu1994
Copy link
Member

Fixed in 0b94cf6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Status: Needs Triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iluuu1994 @DanielEScherzer