Skip to content

docs: fix build status on README.md #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2024
Merged

docs: fix build status on README.md #558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Build Status
------------
[![Build Status](https://travis-ci.org/php-memcached-dev/php-memcached.png)](https://travis-ci.org/php-memcached-dev/php-memcached)
![Build Status](https://github.com/php-memcached-dev/php-memcached/actions/workflows/build-and-test.yml/badge.svg?branch=master)
Copy link
Collaborator

@sodabrew sodabrew May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe merged too soon, I'd suggest linking to https://github.com/php-memcached-dev/php-memcached/actions as the target of this image

Copy link
Contributor Author

@blkperl blkperl May 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sodabrew what do you mean?

I only saw a few options in
https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/adding-a-workflow-status-badge

Copy link
Collaborator

@sodabrew sodabrew May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found on StackOverflow an example [<img src="path/to/image.png">](https://link-to-your-URL/) -- I don't know if it will work for an absolute img src url vs. relative path within the repo. Apparently the syntax for this changed in 2023!


Description
-----------
Expand All @@ -23,7 +23,7 @@ Dependencies
------------

php-memcached 3.x:
* Supports PHP 7.0 - 8.2 or higher.
* Supports PHP 7.0 - 8.3 or higher.
* Requires libmemcached 1.x or higher.
* Optionally supports igbinary 2.0 or higher.
* Optionally supports msgpack 2.0 or higher.
Expand Down