Don't strip quotation marks at the end of normal chat messages after encoding. #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaneshKandu
added a commit
that referenced
this pull request
Feb 24, 2022
…encoding. Don't strip quotation marks at the end of normal chat messages after encoding. #13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that a message ends with a
", json_encode encodes it to a\", and trim removes that quotation mark since after it there is only one quotation mark more.Messages that end like that are then stored in the database and since the encoded message is invalid json, users see empty messages.
To fix this i propose changing the trim() call to calling substr and removing explicitly just the first and last character.