Remove some unused fields from InternalKey #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeltz
approved these changes
Aug 7, 2025
AndersAstrand
force-pushed
the
tde/remove-unused-fields-from-internal-key
branch
from
5d5562c to
1c97847
Compare
jeltz
approved these changes
Aug 7, 2025
AndersAstrand
force-pushed
the
tde/remove-unused-fields-from-internal-key
branch
from
1c97847 to
5b0c7c7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (82.00%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #507 +/- ##
==================================================
Coverage 82.00% 82.00%
==================================================
Files 24 24
Lines 3162 3162
Branches 514 514
==================================================
Hits 2593 2593
Misses 460 460
Partials 109 109
🚀 New features to boost your workflow:
|
Add them as unused fields in the TDEMapEntry structure however, so we do not affect existing key files.
AndersAstrand
force-pushed
the
tde/remove-unused-fields-from-internal-key
branch
from
5b0c7c7 to
b25eab5
Compare
jeltz
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add them as reserved fields in the TDEMapEntry structure however, so we do not affect existing key files.