Remove RelFileLocator from the WAL key file #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It happened to work by coincidence since the two structs had the same shape but is a bug waiting to happen.
Since the RelFileLocator has never actually been used for WAL keys we can remove all traces of it from the new file and from the code.
jeltz
force-pushed
the
tde/clean-key-file-split-locator
branch
from
d8f9c24 to
57a7937
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (82.00%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #503 +/- ##
=====================================================
- Coverage 82.03% 82.00% -0.04%
=====================================================
Files 25 25
Lines 3168 3162 -6
Branches 514 514
=====================================================
- Hits 2599 2593 -6
Misses 460 460
Partials 109 109
🚀 New features to boost your workflow:
|
dAdAbird
approved these changes
Aug 7, 2025
dutow
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the RelFileLocator has never actually been used for WAL keys we can remove all traces of it from the new file an from the code.
We also fix a bug where the wrong struct was used for calculating an offset.