Remove our own shared memory tooling #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (85.23%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #408 +/- ##
=====================================================
- Coverage 85.51% 85.23% -0.28%
=====================================================
Files 22 21 -1
Lines 2547 2499 -48
Branches 389 385 -4
=====================================================
- Hits 2178 2130 -48
Misses 293 293
Partials 76 76
🚀 New features to boost your workflow:
|
jeltz
force-pushed
the
tde/clean-shmem2
branch
2 times, most recently
from
8edf4c6 to
7971e17
Compare
AndersAstrand
approved these changes
Jun 10, 2025
Since the only thing our key provider code does with shared memory is look up a LWLock tranche it is quite a waste of lines of codes to use our own layer on top of the PostgreSQL shared memory.
Since it just has one user now let's remove our own shared memory code and remove a lot of generic code that we do not need.
Now that we have removed our shared memory tools the remaining contents of the header can be moved elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an own layer on top of PostgreSQL's shared memory utilities which was of doubtful usefulness since while it may have saved a few bytes of memory if we would have had many users of the system it also made it harder to inspect our allocations since a lot of the built-in tooling could not be used.
It also turns out there was only one serious user of the code, the principal key code. The other user, the key provider code, actually did not store anything interesting in shared memory at all. And with only on real user these inhouse utilities added even less value.