Use OpenTransientFile() instead of BasicOpenFile()

[jeltz]

By using OpenTransientFile() we do not have to close file descriptors on error plus PostgreSQL will check if we have forgot to close any files on commit.

This change made us find one instance where we had forgot to close a file which is also fixed in this commit.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.69%. Comparing base (4575c03) to head (a4ff24d).

❌ Your project status has failed because the head coverage (85.69%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@                  Coverage Diff                  @@
##           TDE_REL_17_STABLE     #400      +/-   ##
=====================================================
+ Coverage              85.48%   85.69%   +0.20%     
=====================================================
  Files                     22       22              
  Lines                   2536     2531       -5     
  Branches                 387      388       +1     
=====================================================
+ Hits                    2168     2169       +1     
+ Misses                   294      288       -6     
  Partials                  74       74              

Components	Coverage Δ
access	84.40% <100.00%> (+0.20%)	⬆️
catalog	88.90% <87.50%> (+0.30%)	⬆️
common	91.80% <ø> (ø)
encryption	72.56% <ø> (ø)
keyring	72.77% <87.50%> (+0.34%)	⬆️
src	91.42% <ø> (ø)
smgr	97.43% <ø> (+0.01%)	⬆️
transam	∅ <ø> (∅)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.