PG-1651 Do not try the fetch key from old provider when changing provider settings #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ider settings We used to verify that all keys are still accessible by fetching the key from cache and if not cached from the current provider settings when changing the key provider setting but this makes things fragile and prone to user error in the case where a principal key is not cached. Instead we can rely on the AEAD tag in the header of each file, which has two advantages 1) the cached and non-cache code path works the same and 2) we do not need to care about if the old provider is accessible, only that the new one is and that it contains the right key (i.e. one that can verify the header tag).
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (85.25%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #395 +/- ##
=====================================================
+ Coverage 85.20% 85.25% +0.05%
=====================================================
Files 22 22
Lines 2534 2536 +2
Branches 384 386 +2
=====================================================
+ Hits 2159 2162 +3
+ Misses 301 300 -1
Partials 74 74
🚀 New features to boost your workflow:
|
dAdAbird
approved these changes
Jun 5, 2025
| @@ -677,9 +677,7 @@ pg_tde_get_key_info(PG_FUNCTION_ARGS, Oid dbOid) | |||
| #endif /* FRONTEND */ | |||
|
|
|||
| /* | |||
| * Gets principal key form the keyring. | |||
| * | |||
| * Caller should hold an exclusive tde_lwlock_enc_keys lock | |||
There was a problem hiding this comment.
what's the reason for removing this comment?
There was a problem hiding this comment.
Because the assert is there and protects the caller.
dutow
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to verify that all keys are still accessible by fetching the key from cache and if not cached from the current provider settings when changing the key provider setting but this makes things fragile and prone to user error in the case where a principal key is not cached.
Instead we can rely on the AEAD tag in the header of each file, which has two advantages 1) the cached and non-cache code path works the same and 2) we do not need to care about if the old provider is accessible, only that the new one is and that it contains the right key (i.e. one that can verify the header tag).