PG-1592 Return all nulls for key info when no key #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeltz
force-pushed
the
tde/key-info-return
branch
from
365fdcd to
b635e50
Compare
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (85.20%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #391 +/- ##
=====================================================
- Coverage 85.23% 85.20% -0.04%
=====================================================
Files 22 22
Lines 2533 2534 +1
Branches 384 384
=====================================================
Hits 2159 2159
- Misses 300 301 +1
Partials 74 74
🚀 New features to boost your workflow:
|
jeltz
force-pushed
the
tde/key-info-return
branch
2 times, most recently
from
ca9b84f to
ecf2b9b
Compare
Since no key being configured is not an error we instead of raising the error we return a tuple with all fields set to NULL. This is a pattern used by other PostgreSQL functions. Also add a more explicit test for pg_tde_verify_server_key().
jeltz
force-pushed
the
tde/key-info-return
branch
from
ecf2b9b to
a8d079f
Compare
dAdAbird
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since no key being configured is not an error we instead of raising the error we return a tuple with all fields set to NULL. This is a pattern used by other PostgreSQL functions.
Also add a more explicit test for
pg_tde_verify_server_key().