Fix non-functioning helper sql function #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function did not work as it tried to create a vault-v2 provider using kmip options.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (85.42%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #384 +/- ##
==================================================
Coverage 85.42% 85.42%
==================================================
Files 22 22
Lines 2607 2607
Branches 395 395
==================================================
Hits 2227 2227
Misses 305 305
Partials 75 75
🚀 New features to boost your workflow:
|
jeltz
approved these changes
Jun 2, 2025
|
I think this is fine to merge without tests for now but I think the real solution is to remove all of these helper functions as part of the work to remove external parameters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function did not work as it tried to create a vault-v2 provider using kmip options.
This having gone unnoticed however leads me to another question. Are these "helpers" taking json input for all parameters really useful? I'd say they are not and anyone wanting "advanced" configuration should instead use the "raw" pg_tde_add_new_database_key_provider() et.al.