[PG-1635] Return void from add/change key provider functions #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The returned provider id was not useful for end-users as they cannot do anything with it. They always use the provider name when interacting with these settings. If they really want to see these ids they can easily just use the functions to list all providers to see them. The reason for this change is that it might be confusing for users when the function to create a global provider returns -1 on success without any indication that it's just the generated id and not an error code.
jeltz
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The returned provider id was not useful for end-users as they cannot do anything with it. They always use the provider name when interacting with these settings.
If they really want to see these ids they can easily just use the functions to list all providers to see them.
The reason for this change is that it might be confusing for users when the function to create a global provider returns -1 on success without any indication that it's just the generated id and not an error code.