Replace map entry/key type flags with an enum #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeltz
force-pushed
the
tde/map-entry-flags
branch
3 times, most recently
from
ed57e0f to
a6b4f5b
Compare
dutow
reviewed
May 26, 2025
| typedef enum | ||
| { | ||
| MAP_ENTRY_EMPTY = 0, | ||
| TDE_KEY_TYPE_SMGR = 1, |
There was a problem hiding this comment.
If we are also changing the values, it is probably a good idea to also change PG_TDE_FILEMAGIC
There was a problem hiding this comment.
If we are also changing the values, it is probably a good idea to also change
PG_TDE_FILEMAGIC
Do we need to care about existing clusters before the june release?
There was a problem hiding this comment.
No. I don't think that we should create an upgrade path, but it's a good practice to prevent accidents. These files might stay there even if somebody uninstalled the previous rc2 extension.
There was a problem hiding this comment.
Agreed. Pushed a version bump.
AndersAstrand
approved these changes
May 26, 2025
The code was much harder to understand than necessary due to the type being encoded as a bitmask where most combinations of bits were invalid. Using an enum makes the five different states which we encoded much more obvious. The WAL_INVALID state is a bit special since it is only ever set on the key and never on the map entry itself.
jeltz
force-pushed
the
tde/map-entry-flags
branch
from
a6b4f5b to
cebd5a3
Compare
dutow
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was much harder to understand than necessary due to the type being encoded as a bitmask where most combinations of bits were invalid. Using an enum makes the five different states which we encoded much more obvious.
The
WAL_INVALIDstate is a bit special since it is only ever set on the key and never on the map entry itself.