[PG-1580] Add tests for pg_tde_change_key_provider #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (84.90%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #352 +/- ##
=====================================================
+ Coverage 80.49% 84.90% +4.40%
=====================================================
Files 22 22
Lines 2605 2610 +5
Branches 399 396 -3
=====================================================
+ Hits 2097 2216 +119
+ Misses 430 314 -116
- Partials 78 80 +2
🚀 New features to boost your workflow:
|
The configuration json generated by the pg_tde_change_key_provider CLI tool was not valid since it contained an unexpected field. Also include provider id in the record before attempting the modification as otherwise the modify function throws an error.
The pg_tde_change_key_provider CLI tool usage information did not contain information about how to update a global key provider.
This tool is only meant to be used in dire circumstances and whoever is using it should be sure what they want to do. Also remove information about "running postgres processes" from usage information as the tool will refuse to do anything if the cluster is running.
This was missed in 443d33c
This seems to always have been incorrect.
This seems like the right thing to do.
Since there is precedent for using "normal" tap assertions for CLI tools, they are also used here for easier debugging of test failures.
AndersAstrand
force-pushed
the
tde/add-tests-for-pg_tde_change_key_provider
branch
from
4eba458 to
ff55f91
Compare
jeltz
approved these changes
May 22, 2025
| )); | ||
| is($options->{token}, 'secret-token', | ||
| 'token is set correctly for vault-v2 provider'); | ||
| is( $options->{url}, |
There was a problem hiding this comment.
Is this space a perl(un)tidy thing?
There was a problem hiding this comment.
yes... i regret adding that to CI soooo much :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make it actually work and give correct usage instructions.
It seems like meson doesn't support subtests in TAP, otherwise these tests would have been so much nicer