Revoke all from public on c functions

[AndersAstrand]

It feels better to have a white list of publicly executable functions than a black list.

I wasn't sure where tests that asserts that CREATE EXTENSION does the right thing belongs, but it felt like basic usage to me so I put the assertion that this is done there.

We don't have any security definer functions, but if we did they would also need to be revoked from public by default.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.40%. Comparing base (84d1b56) to head (0f3ad27).

❌ Your project status has failed because the head coverage (85.40%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@                Coverage Diff                 @@
##           TDE_REL_17_STABLE     #318   +/-   ##
==================================================
  Coverage              85.39%   85.40%           
==================================================
  Files                     22       22           
  Lines                   2602     2603    +1     
  Branches                 393      394    +1     
==================================================
+ Hits                    2222     2223    +1     
  Misses                   304      304           
  Partials                  76       76           

Components	Coverage Δ
access	84.20% <ø> (ø)
catalog	88.20% <ø> (ø)
common	91.80% <ø> (ø)
encryption	73.45% <ø> (ø)
keyring	72.00% <ø> (ø)
src	91.40% <ø> (ø)
smgr	97.43% <ø> (+0.01%)	⬆️
transam	∅ <ø> (∅)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dutow]

Maybe this test could skip this condition, and check all functions? We only allow a few functions by default, so the list would be short, and then it would also verify the sql language functions.

[AndersAstrand]

If we want to check the sql language functions we should probably just do the ones that are SECURITY DEFINER, which currently is none. I did consider adding that, but as there are none it felt a bit weird 🙂

[AndersAstrand]

Added security definer functions for considerations if there ever are any :) .

[jeltz]

I support the general idea but I am pretty sure we have some functions which should be default be callable by anyone, e.g. pg_tde_is_encrypted().

[AndersAstrand]

I support the general idea but I am pretty sure we have some functions which should be default be callable by anyone, e.g. pg_tde_is_encrypted().

Added pg_tde_is_encrypted() to whitelist.

[AndersAstrand]

Added pg_tde_version() to whitelist per request.