Skip to content

Small optimization of zero hashCode #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TangBean wants to merge 1 commit into from
Closed

Small optimization of zero hashCode #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/main/java/at/favre/lib/bytes/Bytes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,6 +746,10 @@ public static Bytes random(int length, Random random) {
private final ByteOrder byteOrder;
private final BytesFactory factory;
private transient int hashCodeCache;
/**
* Cache if the hash has been calculated as actually being zero, enabling us to avoid recalculating this.
*/
private transient boolean hashCodeIsZero; // Default to false;

Bytes(byte[] byteArray, ByteOrder byteOrder) {
this(byteArray, byteOrder, new Factory());
Expand Down Expand Up @@ -2221,8 +2225,11 @@ public boolean equalsContent(Bytes other) {

@Override
public int hashCode() {
if (hashCodeCache == 0) {
if (hashCodeCache == 0 && !hashCodeIsZero) {
hashCodeCache = Util.Obj.hashCode(internalArray(), byteOrder());
if (hashCodeCache == 0) {
hashCodeIsZero = true;
}
}
return hashCodeCache;
}
Expand Down