-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to resolve automatically Parse Type fields from Custom Schema #6562
Allow to resolve automatically Parse Type fields from Custom Schema #6562
Conversation
Update Moumoums
Codecov Report
@@ Coverage Diff @@
## master #6562 +/- ##
==========================================
- Coverage 93.91% 93.88% -0.04%
==========================================
Files 169 169
Lines 11967 11965 -2
==========================================
- Hits 11239 11233 -6
- Misses 728 732 +4
Continue to review full report at Codecov.
|
@Moumouls can you please add a test case? |
I will add test case soon, finally after many tests on my teams graphql parse server (with advanced GraphQL use), i figured out that a simple merge (transfer custom type to auto) combine to replace last types seems to solve all issues and all types/mutation/queries are correctly overloaded. |
Postgres fail again |
@davimacedo test case added ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
An error occur when you write a custom Mutation/Query that return an auto generated type like
User
,SomeClass
...For example, currently it fails
So we need to inject Auto GraphQL Type fields into the custom one to return a valid
User
.Also we need to avoid doing this for roots types to prevent wrong routing during schema execution.