Skip to content

Resolves Problem with PHP 7.2 Throwing Error on count #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paquettg merged 1 commit into from
Feb 11, 2018
Merged

Resolves Problem with PHP 7.2 Throwing Error on count #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/PHPHtmlParser/Selector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
use PHPHtmlParser\Dom\InnerNode;
use PHPHtmlParser\Dom\LeafNode;
use PHPHtmlParser\Exceptions\ChildNotFoundException;
use Countable;

/**
* Class Selector
Expand Down Expand Up @@ -168,7 +169,9 @@ protected function parseSelectorString($selector)
protected function seek(array $nodes, array $rule, array $options)
{
// XPath index
if (count($rule['tag']) > 0 &&
if ($rule['tag'] instanceof Countable &&
Copy link

@alcaeus alcaeus Nov 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$rule['tag'] is compared with a string below, so this check is incorrect. I suggest checking against !empty instead of count.

count($rule['tag']) > 0 &&
$rule['key'] instanceof Countable &&
Copy link

@alcaeus alcaeus Nov 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$rule['key'] is compared with an int below, so this check is incorrect as well. Since it's supposed to be an index, I'd suggest to check $rule['key'] > 0

count($rule['key']) > 0 &&
is_numeric($rule['key'])
) {
Expand Down