API (string dtype): implement hierarchy (NA > NaN, pyarrow > python) for consistent comparisons between different string dtypes #61138
+98
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for consistent comparisons between different string dtypes
mroeschke
reviewed
Mar 19, 2025
| expected = pd.array([None, None, None], dtype=expected_dtype) | ||
| tm.assert_extension_array_equal(result, expected) | ||
| # # with list | ||
| # other = [None, None, "c"] |
There was a problem hiding this comment.
Did you want to implement testing this in this PR?
There was a problem hiding this comment.
Yes, this was already implemented, just need to add this case back to the test. The original "array" test was actually testing with a list. I updated the test to now actually use an array (parametrized with all the different dtypes, to get all combinations of dtypes in both operands), and added a separate test with just the list.
jorisvandenbossche
force-pushed
the
string-dtype-comparison-methods-priority
branch
from
9a0c382 to
4ebd93b
Compare
rhshadrach
added
the
Numeric Operations
Comment on lines
-350
to
-352
| result = getattr(a, op_name)(pd.NA) | ||
| expected = pd.array([None, None, None], dtype=expected_dtype) | ||
| tm.assert_extension_array_equal(result, expected) |
There was a problem hiding this comment.
For this case of comparing with NA, we already have a dedicated test just above, so removing it here
rhshadrach
requested changes
Mar 26, 2025
Comment on lines
241
to
246
| using_infer_string | ||
| and all_arithmetic_operators == "__radd__" | ||
| and ( | ||
| (dtype.na_value is pd.NA) or (dtype.storage == "python" and HAS_PYARROW) | ||
| dtype.na_value is pd.NA | ||
| and not (not HAS_PYARROW and dtype.storage == "python") | ||
| ) |
There was a problem hiding this comment.
Nit: This would be a bit cleaner as
using_infer_string
and all_arithmetic_operators == "__radd__"
and dtype.na_value is pd.NA
and (HAS_PYARROW or dtype.storage == "pyarrow")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #60639
This does not yet handle the case of comparison to object dtype.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.