Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_datetimes.py: fix literal string #60820

Merged
merged 5 commits into from
Mar 3, 2025

Conversation

haampie
Copy link
Contributor

@haampie haampie commented Jan 30, 2025

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@haampie haampie requested a review from MarcoGorelli as a code owner January 30, 2025 13:16
@haampie haampie force-pushed the hs/fix/literal-string branch from 956db27 to 211429a Compare January 30, 2025 13:17
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well-spotted, thanks @haampie

@MarcoGorelli MarcoGorelli added Clean Error Reporting Incorrect or improved errors from pandas labels Jan 30, 2025
@MarcoGorelli MarcoGorelli added this to the 3.0 milestone Jan 30, 2025
@MarcoGorelli
Copy link
Member

If you just add a whatsnew entry to 3.0.0 I think this can be merged

@haampie
Copy link
Contributor Author

haampie commented Jan 31, 2025

Not familiar with the format, let me know if this is what you mean, otherwise feel free to push to this branch.

Copy link
Contributor

github-actions bot commented Mar 3, 2025

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Mar 3, 2025
@haampie
Copy link
Contributor Author

haampie commented Mar 3, 2025

not stale

@mroeschke
Copy link
Member

pre-commit.ci autofix

@mroeschke mroeschke removed the Stale label Mar 3, 2025
@mroeschke mroeschke merged commit 010ffe2 into pandas-dev:main Mar 3, 2025
42 checks passed
@mroeschke
Copy link
Member

Thanks @haampie

tonyyuyiding pushed a commit to tonyyuyiding/pandas that referenced this pull request Mar 4, 2025
* test_datetimes.py: fix literal string

* fix test

* fix repeated whitespace

* add whatsnew entry

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants