Implement Buffer Protocol for PandasBuffer #55671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
commented
Oct 24, 2023
pandas/_libs/buffer.pyx
Outdated
| cdef Py_ssize_t[1] shape = tuple((self.bufsize // itemsize,)) | ||
| cdef Py_ssize_t[1] strides = tuple((itemsize,)) | ||
|
|
||
| buffer.buf = <void*>ptr |
There was a problem hiding this comment.
There might be a better way of doing this overall, but I figured since self.ptr returns an int it is an easy bolt on to the existing design
5 tasks
|
Need to investigate the validity buffer in more detail. Arrow would use bits for that so some of the sizing may be off, if that hasn't already been converted to bytes elsewhere in the interchange |
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Closing for now - may revisit later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #55227 (comment)