Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Fix version script #54525

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Conversation

lithomas1
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Had a small issue with the conda packages, since there was a bug in this script where it wasn't picking up the version properly when built from sdist (outside of the package dir).

@lithomas1 lithomas1 added the Build Library building on various platforms label Aug 13, 2023
@lithomas1 lithomas1 added this to the 2.1 milestone Aug 13, 2023
@mroeschke mroeschke merged commit bdd44e9 into pandas-dev:main Aug 15, 2023
@mroeschke
Copy link
Member

Thanks @lithomas1

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 15, 2023
@lithomas1 lithomas1 deleted the fix-build-version branch August 15, 2023 19:35
phofl pushed a commit that referenced this pull request Aug 15, 2023
Backport PR #54525: BLD: Fix version script

Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com>
mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Aug 18, 2023
* BLD: Fix the version generation script

* Update config.yml

* Update config.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants