Skip to content

Revert "STYLE use pandas-dev-flaker (#40906) #50519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add xfail to request
  • Loading branch information
MarcoGorelli committed Jan 3, 2023
commit 75626216290070ea6b6ef4d5b2a55bf5b7a8fc72
6 changes: 4 additions & 2 deletions pandas/tests/io/pytables/test_round_trip.py
Original file line number Diff line number Diff line change
Expand Up @@ -349,15 +349,17 @@ def test_index_types(setup_path):
_check_roundtrip(ser, func, path=setup_path)


def test_timeseries_preepoch(setup_path):
def test_timeseries_preepoch(setup_path, request):

dr = bdate_range("1/1/1940", "1/1/1960")
ts = Series(np.random.randn(len(dr)), index=dr)
try:
_check_roundtrip(ts, tm.assert_series_equal, path=setup_path)
except OverflowError:
if is_platform_windows():
pytest.mark.xfail("known failure on some windows platforms")
request.node.add_marker(
pytest.mark.xfail("known failure on some windows platforms")
)
else:
Copy link
Member

@mroeschke mroeschke Jan 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think this else should be removed now too so the xfail will be recognized after the raise

raise

Expand Down