ENH: Suppport masks in median groupby algo #48387
Merged
+102
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Groupby
NA - MaskedArrays
rhshadrach
requested changes
Sep 5, 2022
pandas/_libs/groupby.pyx
Outdated
| @@ -93,6 +124,13 @@ cdef inline float64_t median_linear(float64_t* a, int n) nogil: | |||
| a = tmp | |||
| n -= na_count | |||
|
|
|||
| return calc_median_linear(a, n, na_count) | |||
There was a problem hiding this comment.
Could you free a here instead of in calc_median_linear? While it does mean you'll have to free in both this method and the masked version, it makes calc_median_linear have no side-effects.
There was a problem hiding this comment.
Moved it, my train of thought went the other way, if moved inside the function the caller would not forget it. But no real preference on my side
mroeschke
approved these changes
Sep 6, 2022
|
Thanks @phofl |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* ENH: Suppport masks in median groupby algo * Avoid float cast * Out dtype * Add cast * Revert algos * Add whatsnew * Deduplicate * Fix * Add type hints * Move free
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Only a small speed up (5-10%, depending on the number of NAs). In general, this is needed to streamline the code base in ops.py after everything supports masks.