-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WEB: Update to jupyterlite==0.1.0b12
#48329
Conversation
jupyterlite==0.1.0b12
jupyterlite==0.1.0b12
Thanks @jorisvandenbossche for reporting the issue today. I tried the built archive locally downloaded from https://github.com/pandas-dev/pandas/actions/runs/2964426541, and it seems to be working well with the update: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jtpio, lgtm.
Btw, would it be easy to show a spinner or even the word Loading...
while the webassembly binary is being downloaded and loaded? I think it'd make the user experience much nicer, since this can take several seconds to be available.
Thanks @jtpio. Agreed, a loading indicator would be a nicer user experience (to set expectation of the activity in the background) |
Thanks all.
Yes that's a good point and it is currently tracked this in jupyterlite/jupyterlite#619, which could be applied to all applications (lab, notebook, repl). |
* Update to `jupyterlite==0.1.0b12` * Update requirements-dev.txt
Update to the latest
jupyterlite
release to bring some more bug fixes and improvements.This should help fix an issue with the current repl failing to load
closes #xxxx (Replace xxxx with the Github issue number)Tests added and passed if fixing a bug or adding a new featureAdded type annotations to new arguments/methods/functions.Added an entry in the latestdoc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.