Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB: Update to jupyterlite==0.1.0b12 #48329

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

jtpio
Copy link
Contributor

@jtpio jtpio commented Aug 31, 2022

Update to the latest jupyterlite release to bring some more bug fixes and improvements.

This should help fix an issue with the current repl failing to load

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@jtpio jtpio changed the title Update to jupyterlite==0.1.0b12 WEB: Update to jupyterlite==0.1.0b12 Aug 31, 2022
@jtpio
Copy link
Contributor Author

jtpio commented Aug 31, 2022

Thanks @jorisvandenbossche for reporting the issue today.

I tried the built archive locally downloaded from https://github.com/pandas-dev/pandas/actions/runs/2964426541, and it seems to be working well with the update:

image

@jtpio jtpio marked this pull request as ready for review August 31, 2022 20:46
@datapythonista datapythonista added the Web pandas website label Sep 1, 2022
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtpio, lgtm.

Btw, would it be easy to show a spinner or even the word Loading... while the webassembly binary is being downloaded and loaded? I think it'd make the user experience much nicer, since this can take several seconds to be available.

@mroeschke mroeschke added this to the 1.6 milestone Sep 1, 2022
@mroeschke mroeschke merged commit 003f125 into pandas-dev:main Sep 1, 2022
@mroeschke
Copy link
Member

Thanks @jtpio. Agreed, a loading indicator would be a nicer user experience (to set expectation of the activity in the background)

@jtpio jtpio deleted the update-jupyterlite branch September 2, 2022 07:34
@jtpio
Copy link
Contributor Author

jtpio commented Sep 2, 2022

Thanks all.

a loading indicator

Yes that's a good point and it is currently tracked this in jupyterlite/jupyterlite#619, which could be applied to all applications (lab, notebook, repl).

@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
* Update to `jupyterlite==0.1.0b12`

* Update requirements-dev.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web pandas website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants