Skip to content

REGR: properly update DataFrame cache in Series.__setitem__ #48215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 26, 2022
Merged

REGR: properly update DataFrame cache in Series.__setitem__ #48215

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0f7f932
REGR: properly update DataFrame cache in Series.__setitem__
jorisvandenbossche Aug 23, 2022
f8805df
Merge remote-tracking branch 'upstream/main' into regr-series-cache-leak
jorisvandenbossche Aug 23, 2022
b567d02
whatsnew
jorisvandenbossche Aug 23, 2022
253a7a5
add test
jorisvandenbossche Aug 23, 2022
2ec2673
Merge remote-tracking branch 'upstream/main' into regr-series-cache-leak
jorisvandenbossche Aug 25, 2022
f32ef47
skip for array managet (accesses blocks)
jorisvandenbossche Aug 25, 2022
8c75621
Merge remote-tracking branch 'upstream/main' into regr-series-cache-leak
jorisvandenbossche Aug 25, 2022
3dc008a
update whatsnew
jorisvandenbossche Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
whatsnew
  • Loading branch information
@jorisvandenbossche
jorisvandenbossche committed Aug 23, 2022
commit b567d025a555473dc5eba9c74ec2375f846685f4
1 change: 1 addition & 0 deletions doc/source/whatsnew/v1.4.4.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Fixed regressions
- Fixed regression in :meth:`DataFrame.loc` setting a length-1 array like value to a single value in the DataFrame (:issue:`46268`)
- Fixed regression when slicing with :meth:`DataFrame.loc` with :class:`DateOffset`-index (:issue:`46671`)
- Fixed regression in setting ``None`` or non-string value into a ``string``-dtype Series using a mask (:issue:`47628`)
- Fixed regression in updating a DataFrame column through :meth:`Series.__setitem__` (:issue:`47172`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Series.__setitem__ doesn't render? so perhaps reword and maybe should also mention memory leak or that the values were not updated inplace using chained indexing with assignment?

- Fixed regression in :meth:`DataFrame.select_dtypes` returning a view on the original DataFrame (:issue:`48090`)
- Fixed regression using custom Index subclasses (for example, used in xarray) with :meth:`~DataFrame.reset_index` or :meth:`Index.insert` (:issue:`47071`)
- Fixed regression in :meth:`DatetimeIndex.intersection` when the :class:`DatetimeIndex` has dates crossing daylight savings time (:issue:`46702`)
Expand Down