-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos #47275
Fix typos #47275
Conversation
thanks - any idea why the check didn't already pick these up? |
@MarcoGorelli The hook's config excludes all files that aren't Python, rST or Markdown and not in - repo: https://github.com/codespell-project/codespell
rev: v2.1.0
hooks:
- id: codespell
types_or: [python, rst, markdown]
files: ^(pandas|doc)/ I happened to have one of my commits aborted by this hook and decided to check all files with it. |
You could probably get rid of this rule |
does this PR fix all the remaining warnings? If so, do you want to remove it this PR please? |
Almost. There is 1 remaining: web/pandas/try.md:9: ines ==> lines Line 9 in 019574d
Not sure that file is actually used? 2 years old and still says args: [--ignore-words-list, ines] to hook config. |
Could the ignore-regex in Lines 161 to 163 in 4ea3efe
be modified to ignore this? |
Oh, didn't see |
also fix typos fempto -> femto
Co-authored-by: Marco Edward Gorelli <marcogorelli@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Feel free to merge when ready @MarcoGorelli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @janosh !
* fix codespell violations * drop rule files: ^(pandas|doc)/ from codespell pre-commit config also fix typos fempto -> femto * improve codespell ignore-regex in setup.cfg Co-authored-by: Marco Edward Gorelli <marcogorelli@protonmail.com> Co-authored-by: Marco Edward Gorelli <marcogorelli@protonmail.com>
Some violations raised by the codespell
pre-commit
hook I noticed during #46718.doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.