Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #47275

Merged
merged 4 commits into from
Jun 8, 2022
Merged

Fix typos #47275

merged 4 commits into from
Jun 8, 2022

Conversation

janosh
Copy link
Contributor

@janosh janosh commented Jun 7, 2022

Some violations raised by the codespell pre-commit hook I noticed during #46718.

@MarcoGorelli
Copy link
Member

thanks - any idea why the check didn't already pick these up?

@janosh
Copy link
Contributor Author

janosh commented Jun 7, 2022

@MarcoGorelli The hook's config excludes all files that aren't Python, rST or Markdown and not in pandas/ or doc/:

-   repo: https://github.com/codespell-project/codespell
    rev: v2.1.0
    hooks:
    -   id: codespell
        types_or: [python, rst, markdown]
        files: ^(pandas|doc)/

I happened to have one of my commits aborted by this hook and decided to check all files with it.

@janosh
Copy link
Contributor Author

janosh commented Jun 7, 2022

You could probably get rid of this rule files: ^(pandas|doc)/.

@MarcoGorelli
Copy link
Member

You could probably get rid of this rule files: ^(pandas|doc)/.

does this PR fix all the remaining warnings? If so, do you want to remove it this PR please?

@janosh
Copy link
Contributor Author

janosh commented Jun 7, 2022

does this PR fix all the remaining warnings? If so, do you want to remove it this PR please?

Almost. There is 1 remaining:

web/pandas/try.md:9: ines ==> lines

<script src="https://combinatronics.com/ines/juniper/v0.1.0/dist/juniper.min.js"></script>

Not sure that file is actually used? 2 years old and still says _(links will be added soon)_. Either delete file or add

args: [--ignore-words-list, ines]

to hook config.

@MarcoGorelli
Copy link
Member

Could the ignore-regex in

pandas/setup.cfg

Lines 161 to 163 in 4ea3efe

[codespell]
ignore-words-list = ba,blocs,coo,hist,nd,sav,ser
ignore-regex = https://(\w+\.)+

be modified to ignore this?

@janosh
Copy link
Contributor Author

janosh commented Jun 7, 2022

Oh, didn't see ignore-words-list was already set in setup.cfg.

janosh and others added 2 commits June 8, 2022 11:38
Co-authored-by: Marco Edward Gorelli <marcogorelli@protonmail.com>
@MarcoGorelli MarcoGorelli added the Code Style Code style, linting, code_checks label Jun 8, 2022
@MarcoGorelli MarcoGorelli added this to the 1.5 milestone Jun 8, 2022
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to merge when ready @MarcoGorelli

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @janosh !

@MarcoGorelli MarcoGorelli merged commit aa85f02 into pandas-dev:main Jun 8, 2022
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
* fix codespell violations

* drop rule files: ^(pandas|doc)/ from codespell pre-commit config

also fix typos fempto -> femto

* improve codespell ignore-regex in setup.cfg

Co-authored-by: Marco Edward Gorelli <marcogorelli@protonmail.com>

Co-authored-by: Marco Edward Gorelli <marcogorelli@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants