Refactor CI code #46346
Closed
Refactor CI code #46346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jonashaag
force-pushed
the
provision-with-micromamba
branch
7 times, most recently
from
767c9dc to
90e5591
Compare
jonashaag
force-pushed
the
provision-with-micromamba
branch
2 times, most recently
from
83bd3fa to
4c2f4cd
Compare
- Drop Azure (move to GHA). - Use mamba-org/provision-with-micromamba to set up Conda envs. - Cache Conda envs. - Use hendrikmuhs/ccache-action to cache C compiliation. - Add Windows 32 bit build. - Drop Ubuntu 32 bit build. - Factor out common GHA code into reusable actions.
jonashaag
force-pushed
the
provision-with-micromamba
branch
from
4c2f4cd to
3008c94
Compare
|
@mroeschke would love your feedback here. |
|
+1 to all the changes, but it would be easier to review (and probably safer) if each of these changes could be made in separate PRs |
|
I can make the following PRs; anything else would require more work but I can do it as well if you want me to.
|
|
Yup those steps would be more digestible to review. |
|
why do we care about windows 32 build? |
|
Acted on this comment. #44453 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this is a lot of changes. Happy to split into multiple PRs if it is too much to review.
Side effect of the changes is that most jobs are ~ 10 minutes faster.