Add benchmark for indexing with .loc for sorted/unsorted DatetimeIndex #46198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 1, 2022 22:13
mroeschke
reviewed
Mar 2, 2022
asv_bench/benchmarks/indexing.py
Outdated
| index = np.array(dti) | ||
| df = DataFrame(index=index, data={"a": 1}) | ||
| df_sort = df.sort_index() | ||
| self.df = df |
There was a problem hiding this comment.
I think one of these should be unsorted. Currently df and df_sort will both be sorted in the index.
You can create the unsorted one like index[10] = index[20] and creating a new DataFrame.
|
@mroeschke Hi The testing pipeline in green. Thank for review. |
mroeschke
reviewed
Mar 3, 2022
added 2 commits
March 5, 2022 00:03
|
@mroeschke Pipeline check in green |
mroeschke
approved these changes
Mar 4, 2022
|
Thanks for following up @weikhor |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…ex (pandas-dev#46198) * add benchmark * add * add benchmark * add * add * add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.