TST: Added tests to check if file exists for read_json. #44911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Dec 15, 2021
| @@ -265,7 +266,8 @@ def test_write_missing_parent_directory(self, method, module, error_class, fn_ex | |||
| (pd.read_hdf, "tables", FileNotFoundError, "h5"), | |||
| (pd.read_stata, "os", FileNotFoundError, "dta"), | |||
| (pd.read_sas, "os", FileNotFoundError, "sas7bdat"), | |||
| (pd.read_json, "os", ValueError, "json"), | |||
| # (pd.read_json, "os", ValueError, "json"), | |||
There was a problem hiding this comment.
Why did you remove this?
Which message is actually shown?
There was a problem hiding this comment.
I removed this because the comments in #29102 asks to create test cases such that the errors returned by read_json returns a FileNotFoundError instead of a ValueError.
There was a problem hiding this comment.
You have to change the actual implementation to raise the correct error
jreback
added
IO JSON
|
@cheungje if you'd merge master and address comments |
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
closing as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29102 already added code to fix the original issue of fixing misleading error messages when trying to open a nonexistent json file. This commit adds test cases.