-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPS: Upgrade Deps for Python 3.10 #43729
DEPS: Upgrade Deps for Python 3.10 #43729
Conversation
lithomas1
commented
Sep 24, 2021
•
edited by jreback
Loading
edited by jreback
- xref BUG: pandas doesn't install on python 3.10 #43715
- closes Use oldest-supported-numpy in pyproject.toml #40307
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
i think we have an issue about this but https://github.com/scipy/oldest-supported-numpy is there a reason we don't just use this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove the line about for python 3.7
There is an open drift #43146 |
can you add a note about the cython change in 1.4 whatsnew |
docs error should be fixed on master if you can rebase |
@lithomas1 lgtm. happy to merge (its a draft), small question. and do you want to try to merge directly to 1.3.4? (and can fix the backport)? |
Thanks for the ping. Its draft because I'm still working on integrating the test from #43146. 1.3.4 would be fine for this. |
Co-authored-by: lithomas1 <thomasli1234567890@gmail.com> Co-authored-by: henryiii <HenrySchreinerIII@gmail.com>
…nto python310-deps-update
Looks good to me. I'd still recommend (not a blocker, even if I had the ability to block things :P ) using Edit: new version looks great. :) |
doc/source/whatsnew/v1.4.0.rst
Outdated
Build | ||
^^^^^ | ||
- The minimum version of Cython needed to compile pandas is now ``0.29.24`` (:issue:`43729`) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is only to work with py310. for older python, previous min of Cython is still ok?
We are backporting this PR? (if so will need to move release note and say that the minimum is for py310 only?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i think ok to move to 1.3.4, this is only a build requirement so ok changing (esp for 3.10) on backport
Thanks @lithomas1 |
This comment has been minimized.
This comment has been minimized.
@lithomas1 needs manual backport when you can |
@lithomas1 does this now close #43715? |
I think asv_bench/asv.conf.json needs to be updated too? (Are the benchmarks running?) Any why is environment.yml and requirements-dev.txt not updated? |