Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPS: Upgrade Deps for Python 3.10 #43729

Merged
merged 41 commits into from
Oct 13, 2021

Conversation

lithomas1
Copy link
Member

@lithomas1 lithomas1 commented Sep 24, 2021

@jreback
Copy link
Contributor

jreback commented Sep 24, 2021

i think we have an issue about this but

https://github.com/scipy/oldest-supported-numpy

is there a reason we don't just use this?

Copy link
Member

@fangchenli fangchenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove the line about for python 3.7

@fangchenli
Copy link
Member

is there a reason we don't just use this?

There is an open drift #43146

@lithomas1 lithomas1 added Compat pandas objects compatability with Numpy or Python functions Dependencies Required and optional dependencies Python 3.10 labels Sep 25, 2021
@jreback jreback added this to the 1.4 milestone Sep 25, 2021
@jreback
Copy link
Contributor

jreback commented Sep 25, 2021

can you add a note about the cython change in 1.4 whatsnew

@jreback
Copy link
Contributor

jreback commented Sep 25, 2021

docs error should be fixed on master if you can rebase

@lithomas1 lithomas1 marked this pull request as draft October 9, 2021 02:49
@jreback
Copy link
Contributor

jreback commented Oct 10, 2021

@lithomas1 lgtm. happy to merge (its a draft), small question. and do you want to try to merge directly to 1.3.4? (and can fix the backport)?

@jreback jreback modified the milestones: 1.4, 1.3.4 Oct 10, 2021
@lithomas1
Copy link
Member Author

Thanks for the ping. Its draft because I'm still working on integrating the test from #43146. 1.3.4 would be fine for this.

lithomas1 and others added 5 commits October 11, 2021 15:32
Co-authored-by: lithomas1 <thomasli1234567890@gmail.com>
Co-authored-by: henryiii <HenrySchreinerIII@gmail.com>
@lithomas1 lithomas1 marked this pull request as ready for review October 11, 2021 23:12
@lithomas1
Copy link
Member Author

Okay, this looks working and the test from #43146 has been added.
@henryiii Can you take one last look? Thanks for all the help so far.

@henryiii
Copy link

henryiii commented Oct 12, 2021

Looks good to me.

I'd still recommend (not a blocker, even if I had the ability to block things :P ) using numpy>=1.21.0; python_version>='3.10'; given this is completely optional segment anyway, and could just as easily be written in a single line numpy>=1.18.5; there is no reason to make it intentionally harder to test on Python 3.11 alphas by not requiring numpy at all - why add something else that could be forgotten? The first Python 3.11 alpha became available via actions/setup-python today, by the way.

Edit: new version looks great. :)

Build
^^^^^
- The minimum version of Cython needed to compile pandas is now ``0.29.24`` (:issue:`43729`)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is only to work with py310. for older python, previous min of Cython is still ok?

We are backporting this PR? (if so will need to move release note and say that the minimum is for py310 only?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i think ok to move to 1.3.4, this is only a build requirement so ok changing (esp for 3.10) on backport

@simonjayhawkins simonjayhawkins merged commit e7efd02 into pandas-dev:master Oct 13, 2021
@simonjayhawkins
Copy link
Member

Thanks @lithomas1

@lumberbot-app

This comment has been minimized.

@simonjayhawkins
Copy link
Member

@lithomas1 needs manual backport when you can

@simonjayhawkins
Copy link
Member

@lithomas1 does this now close #43715?

@simonjayhawkins
Copy link
Member

I think asv_bench/asv.conf.json needs to be updated too? (Are the benchmarks running?) Any why is environment.yml and requirements-dev.txt not updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions Dependencies Required and optional dependencies Python 3.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use oldest-supported-numpy in pyproject.toml
5 participants