Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TYP: make typing DatetimeLikeScalar a Union instead of TypeVar #40540

Merged
merged 2 commits into from
Mar 21, 2021
Merged

TYP: make typing DatetimeLikeScalar a Union instead of TypeVar #40540

merged 2 commits into from
Mar 21, 2021

Conversation

Dr-Irv
Copy link
Contributor

@Dr-Irv Dr-Irv commented Mar 20, 2021

In _typing.py change DatetimeLikeScalar from TypeVar to Union

Allows removal of 4 #type: ignore lines

Per split out from #39501

@Dr-Irv Dr-Irv requested a review from simonjayhawkins March 20, 2021 16:21
@Dr-Irv Dr-Irv mentioned this pull request Mar 20, 2021
Closed
@Dr-Irv Dr-Irv changed the title make typing DatetimeLikeScalar a Union instead of TypeVar TYP: make typing DatetimeLikeScalar a Union instead of TypeVar Mar 21, 2021
@Dr-Irv Dr-Irv mentioned this pull request Mar 21, 2021
Merged
4 tasks
@jreback jreback added the Typing type annotations, mypy/pyright type checking label Mar 21, 2021
@jreback jreback added this to the 1.3 milestone Mar 21, 2021
@jreback jreback merged commit 692b98d into pandas-dev:master Mar 21, 2021
@jreback
Copy link
Contributor

jreback commented Mar 21, 2021

thanks @Dr-Irv

@Dr-Irv Dr-Irv deleted the typevardatetime branch March 22, 2021 11:59
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@Dr-Irv @JulianWgs
make typing DatetimeLikeScalar a Union instead of TypeVar (pandas-dev…
ed18983 
…#40540)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins Awaiting requested review from simonjayhawkins

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Dr-Irv @jreback