Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYP: Index.join, get_indexer, reindex #40390

Closed
wants to merge 6 commits into from

Conversation

jbrockmendel
Copy link
Member

@simonjayhawkins this is technically incorrect bc im specifying returned dtypes as np.intp. Is there a valid way to do this? In working in core.internals trying to figure out whether we want int64 or intp I had to track all of these down to be sure. Would prefer to avoid re-doing this in a few weeks when I forget.

@simonjayhawkins
Copy link
Member

@simonjayhawkins this is technically incorrect bc im specifying returned dtypes as np.intp. Is there a valid way to do this? In working in core.internals trying to figure out whether we want int64 or intp I had to track all of these down to be sure. Would prefer to avoid re-doing this in a few weeks when I forget.

will need to use comments to retain this info for now because "ndarray" expects no type arguments, but 1 given in numpy 1.20.x

I'll start another branch shortly, in the same vien as #36092 checking against numpy master to get visibility of upcoming changes

@jbrockmendel
Copy link
Member Author

OK, I guess I'll mothball this to clear the queue, will re-open when these are supported

@jbrockmendel jbrockmendel added the Mothballed Temporarily-closed PR the author plans to return to label Mar 13, 2021
@jbrockmendel jbrockmendel deleted the cln-intp branch July 21, 2021 00:04
@jbrockmendel jbrockmendel removed the Mothballed Temporarily-closed PR the author plans to return to label Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants