CLN: follow-ups #40000
Merged
CLN: follow-ups #40000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
whoo hoo issue 40000! |
|
looks like the test thats failing here is failing everywhere |
got commited :_> |
can you xfail / fix ? |
woops, will revert
was planning to try to fix it in a bit |
sure |
jreback
reviewed
Feb 24, 2021
| return _take_nd_ndarray(arr, indexer, axis, out, fill_value, allow_fill) | ||
|
|
||
|
|
||
| def _take_nd_ndarray( |
There was a problem hiding this comment.
this is purely for typing right?
There was a problem hiding this comment.
yah mypy complained without it
There was a problem hiding this comment.
simon explained a couple days ago in a different thread that it involves ArrayLike being a TypeVar and not a union
jreback
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.