Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: fix reference to take_1d() #39744

Merged
merged 1 commit into from
Feb 11, 2021
Merged

CI: fix reference to take_1d() #39744

merged 1 commit into from
Feb 11, 2021

Conversation

afeld
Copy link
Member

@afeld afeld commented Feb 11, 2021

Fix for issue noted by @lithomas1 in #39731 (comment), which is causing the Benchmarks to fail.

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@afeld afeld added Bug CI Continuous Integration Needs Review labels Feb 11, 2021
@arw2019 arw2019 mentioned this pull request Feb 11, 2021
Merged
5 tasks
@afeld
Copy link
Member Author

afeld commented Feb 11, 2021

CI / Checks passed, which is what was failing before this pull request. I believe the other failures are flaky tests.

jorisvandenbossche
jorisvandenbossche approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixup!

@jorisvandenbossche jorisvandenbossche merged commit a427887 into pandas-dev:master Feb 11, 2021
@jorisvandenbossche jorisvandenbossche added this to the 1.3 milestone Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Bug CI Continuous Integration
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@afeld @jorisvandenbossche @lithomas1