-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PERF: Rolling/Expanding.cov/corr #39591
Merged
jreback
merged 22 commits into
pandas-dev:master
from
mroeschke:ref/groupby_rolling_pairwise
Feb 5, 2021
Merged
PERF: Rolling/Expanding.cov/corr #39591
jreback
merged 22 commits into
pandas-dev:master
from
mroeschke:ref/groupby_rolling_pairwise
Feb 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Feb 4, 2021
pandas/core/window/rolling.py
Outdated
@@ -591,6 +599,79 @@ def _apply( | |||
result.index = result_index | |||
return result | |||
|
|||
def _apply_pairwise(self, target, other, pairwise, func): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow. can you type the input / output args and add a doc-string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done (a testament to how complex groupby apply is)
jreback
approved these changes
Feb 5, 2021
thanks @mroeschke |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also I think I stumbled on some bugs along the way; added whatsnew and modified the existing tests where necessary.