Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH/POC: EA.isin #38422

Closed
wants to merge 3 commits into from
Closed

Conversation

jbrockmendel
Copy link
Member

Needs tests; the MaskedArray.isin method is not currently reached.

cc @jorisvandenbossche

@jreback jreback added ExtensionArray Extending pandas with custom dtypes or arrays. Indexing Related to indexing on series/frames, not to indexes themselves labels Dec 13, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on this. can you add some generic tests (on the EAs themselves). obviously we cover on Series via dispatching but should still have some tests.

@jbrockmendel
Copy link
Member Author

Closing in favor of #38379

tushushu added a commit to tushushu/pandas that referenced this pull request Dec 27, 2020
@jorisvandenbossche
Copy link
Member

@jbrockmendel thanks for starting this (and sorry for the slow response here), adding isin to the interface sounds like a good idea (eg also in the arrow-backed StringArray, we are going to want to override it).

Taking a look now at #38379, but it might still be worth adding the general interface method in a separate PR (like this one), as it will need some more base extension tests + docs for that.

@jbrockmendel jbrockmendel deleted the enh-ea-isin branch November 20, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: implement fast isin() for nullable dtypes
3 participants