Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN remove unnecessary noqas from pandas/core #36684

Merged
merged 1 commit into from
Sep 27, 2020
Merged

CLN remove unnecessary noqas from pandas/core #36684

merged 1 commit into from
Sep 27, 2020

Conversation

MarcoGorelli
Copy link
Member

  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@jbrockmendel
Copy link
Member

LGTM, nice cleanup

@jreback jreback added the Code Style Code style, linting, code_checks label Sep 27, 2020
@jreback jreback added this to the 1.2 milestone Sep 27, 2020
@jreback jreback merged commit dca6c7f into pandas-dev:master Sep 27, 2020
@jreback
Copy link
Contributor

jreback commented Sep 27, 2020

thanks @MarcoGorelli

ideally if we have a script to see these (maybe a grep is enough), and even better to have a code-check, but not sure how heavy handed that is.

@MarcoGorelli
Copy link
Member Author

LGTM, nice cleanup

Credit to yet another asottile tool https://github.com/asottile/yesqa

@MarcoGorelli MarcoGorelli deleted the yesqa branch September 28, 2020 16:57
@MarcoGorelli MarcoGorelli mentioned this pull request Sep 30, 2020
Merged
1 task
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@MarcoGorelli
remove unnecessary noqas (pandas-dev#36684)
1980e56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcoGorelli @jbrockmendel @jreback