-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD/CI: fix py39 ci #36296 #36393
BLD/CI: fix py39 ci #36296 #36393
Conversation
go ahead and add the commit from #36298 here |
ok can u add a note in 1.1.3 whats new that we support 3.9 and add a note that need cython==0.29.21 in the whats new as well |
cc @pandas-dev/pandas-core backporting this would bump the required cython for 1.1.3 alt we could release this as 1.2 i am ok with doing this to support 3.9 as this is not a runtime dep changing |
Is Cython required for sdist builds or only for git repo builds? |
It's required for sdists, but we set it as a requirement in pyproject.toml so that users don't need it in their env ahead of time. |
I'm fine with bumping the Cython requirement. We just need to update it in a few places (setup.py, pyproject.toml, install.rst, ...) |
@VirosaLi can you update the cython requirements in these places as well.
|
@TomAugspurger @simonjayhawkins if you'd have a quick look. |
I doubt this will autobackport because of differences in the ci setup. so I think OK to merge and then patch as needed if issues on 1.1.x or MacPython. |
@simonjayhawkins yep figured that. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
thanks @VirosaLi really nice! |
@VirosaLi did you want to do the backport? |
Sure, I'll do that later today. |
@@ -62,9 +62,6 @@ matrix: | |||
- arch: arm64 | |||
env: | |||
- JOB="3.7, arm64" PYTEST_WORKERS=8 ENV_FILE="ci/deps/travis-37-arm64.yaml" PATTERN="(not slow and not network and not clipboard)" | |||
- dist: bionic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come we have removed this @VirosaLi did we move 3.9 build to Azure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come we have removed this @VirosaLi did we move 3.9 build to Azure?
It was removed from allow_failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh thanks misread the diff
closes #36296
Need #36298 first.