Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize imports to be compliant with isort (and conventional) #35708

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Reorganize imports to be compliant with isort (and conventional) #35708

merged 1 commit into from
Aug 13, 2020

Conversation

el-iot
Copy link
Contributor

@el-iot el-iot commented Aug 13, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jbrockmendel
Copy link
Member

can you add this file to the files checked by isort in ci/code_checks.sh

@el-iot
Copy link
Contributor Author

el-iot commented Aug 13, 2020

No problem, check out #35709

@jreback
Copy link
Contributor

jreback commented Aug 13, 2020

No problem, check out #35709

ok idealy it would have been in this PR but ok

@jreback jreback added the Code Style Code style, linting, code_checks label Aug 13, 2020
@jreback jreback added this to the 1.2 milestone Aug 13, 2020
@jreback jreback merged commit 288c8ed into pandas-dev:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants