CI: unpin isort 5 (#35134) #35470
Merged
CI: unpin isort 5 (#35134) #35470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
CI
|
@TomAugspurger i'm thinking that if/when we merge this to master maybe we should backport this otherwise we could end up with some auto backports failing and needing to do them manually. wdyt? (or we could defer this until post 1.1.1) |
|
Merging and backporting sounds fine.
…On Thu, Jul 30, 2020 at 9:38 AM Simon Hawkins ***@***.***> wrote:
@TomAugspurger <https://github.com/TomAugspurger> i'm thinking that
if/when we merge this to master maybe we should backport this otherwise we
could end up with some auto backports failing and needing to do them
manually. wdyt?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#35470 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKAOIWWSOSR4IW6HGNGCBTR6GAXXANCNFSM4PL6UEUQ>
.
|
|
will merge this tomorrow if no objections. |
|
Thanks @VirosaLi |
|
@meeseeksdev backport to 1.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 1, 2020
simonjayhawkins
pushed a commit
that referenced
this pull request
Aug 1, 2020
Co-authored-by: Fangchen Li <fangchen.li@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff