Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: raise limit for completion number of columns and warn beyond #35207

Closed
wants to merge 3 commits into from

Conversation

bthyreau
Copy link
Contributor

Hi,

Currently the user-completion (ipython "<tab>") on a dataframe with more than 100 columns will silently ignore some columns, letting an unaware user confused on whether data disapeared.

This is actually documented, and due to an arbitrary limit set to workaround a performance issue ( See #18587 )

Dataframe with more than 100 columns are quite common, so this can potentially affect and suprise many users. Therefore, I suggest to increase that limit to, say, 1000. In any case, it would probably be good to warn the user hitting that limit.

The attached quickfix raises the limit to 1000 and adds a warning beyond.
(Note that I didn't experience any completion latency increasing with the axis size, so I'm not sure whether this limit is still relevant in the first place).

@simonjayhawkins simonjayhawkins added the Performance Memory or execution speed performance label Jul 24, 2020
@simonjayhawkins
Copy link
Member

Thanks @bthyreau for the PR.

The attached quickfix raises the limit to 1000 and adds a warning beyond.

This is still an arbitrary limit. adding a warning is maybe a good idea. Maybe this could be a pandas option to allow users to change this if required.

It maybe better to raise a feature request for more discussion on this topic.

@simonjayhawkins simonjayhawkins added the Needs Discussion Requires discussion from core team before further action label Sep 15, 2020
@arw2019
Copy link
Member

arw2019 commented Nov 22, 2020

I opened #37996 to house the discussion about this.

Thanks @bthyreau for bringing this up! We of course welcome other PRs on this (once there's a consensus on the way forward) or any other issues!

@arw2019 arw2019 closed this Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Discussion Requires discussion from core team before further action Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants