BLD: Increase minimum version of Cython to 0.29.16 #33334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There is a bug that creates code with ctuples that’s not compilable. - This is fixed in 0.29.16. See: cython/cython#2745 cython/cython#1427
- It’s not available in conda.
|
I think you need to bump |
jreback
reviewed
Apr 6, 2020
doc/source/whatsnew/v1.1.0.rst
Outdated
| @@ -92,6 +92,11 @@ Other enhancements | |||
|
|
|||
| .. --------------------------------------------------------------------------- | |||
|
|
|||
| Build Changes | |||
There was a problem hiding this comment.
Can you rename this to Development Changes
5 tasks
jreback
requested changes
Apr 6, 2020
doc/source/whatsnew/v1.1.0.rst
Outdated
| Development Changes | ||
| ^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| - The minimum version of Cython is now the most recent bug-fix version (0.29.16). |
There was a problem hiding this comment.
can you add this PR number here
|
also if you can PR to pandas-wheels repo: https://github.com/MacPython/pandas-wheels/blob/master/azure/posix.yml and https://github.com/MacPython/pandas-wheels/blob/master/azure/windows.yml (these 2 files). |
mgmarino
added a commit
to mgmarino/pandas-wheels
that referenced
this pull request
Apr 7, 2020
This is a follow-up of pandas-dev/pandas#33334
|
@jreback Tests green, PR in wheels repo opened |
TomAugspurger
pushed a commit
to MacPython/pandas-wheels
that referenced
this pull request
Apr 7, 2020
This is a follow-up of pandas-dev/pandas#33334
jreback
approved these changes
Apr 7, 2020
|
thanks @mgmarino (and for the pandas-wheels one) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, this fixes a bug in code returning ctuples
This is a prereq for ENH: Add isocalendar accessor to DatetimeIndex and Series.dt #33220
whatsnew entry