Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added file paths to ignore in linter scripts/validate_unwanted_patterns.py #32927

Merged
merged 3 commits into from
Mar 29, 2020

Conversation

ShaharNaveh
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

While running ./ci/code_checks.sh lint on my local machine I got the output of:

Check for use of not concatenated strings
./asv_bench/env/40d026129f63c107b1ac48bf9ad6964c/lib/python3.6/_sitebuiltins.py:99:String unnecessarily split in two by black. Please merge them manually..
./asv_bench/env/40d026129f63c107b1ac48bf9ad6964c/lib/python3.6/inspect.py:2768:String unnecessarily split in two by black. Please merge them manually..
./asv_bench/env/40d026129f63c107b1ac48bf9ad6964c/lib/python3.6/inspect.py:2890:String unnecessarily split in two by black. Please merge them manually..

....

This fixes it.

@jreback jreback added CI Continuous Integration Performance Memory or execution speed performance labels Mar 29, 2020
@jreback jreback added this to the 1.1 milestone Mar 29, 2020
@jreback jreback merged commit 7b8c405 into pandas-dev:master Mar 29, 2020
@jreback
Copy link
Contributor

jreback commented Mar 29, 2020

sure

@ShaharNaveh ShaharNaveh deleted the CI-unwanted-patterns-ignore branch March 29, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants