Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: collect arithmetic benchmarks #32116

Merged
merged 4 commits into from
Feb 22, 2020

Conversation

jbrockmendel
Copy link
Member

ATM these are scattered, making it tough to a) run just arithmetic-relevant benchmarks and b) determine what we have good benchmark coverage for.

This collects the scattered benchmarks in one place, cleaning up and fleshing these out is for a separate pass.

I also intend to do something analogous for indexing benchmarks.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jbrockmendel jbrockmendel added the Benchmark Performance (ASV) benchmarks label Feb 19, 2020
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure I'd be OK with this

@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Feb 20, 2020
@jorisvandenbossche
Copy link
Member

Note that renaming benchmarks like this defeats somewhat the function of the tracking of benchmarks over time (not when comparing manually two commits, as the old commit is run with the new benchmarks, but for the benchmark machine)

@jbrockmendel
Copy link
Member Author

as the old commit is run with the new benchmarks, but for the benchmark machine

That's an unfortunate side effect, but in the class of problems where "throw hardware at it" is a viable solution.

@jreback jreback merged commit 6ab00bc into pandas-dev:master Feb 22, 2020
@jreback
Copy link
Contributor

jreback commented Feb 22, 2020

@WillAyd for the grant you are looking at, e.g. should take a current benchmark file and run for all released versions as far back as you can (and if anything breaks fix in current benchmarks). we should do this periodically to get good baselines.

@jbrockmendel jbrockmendel deleted the ref-asv-arith branch February 22, 2020 16:08
roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Performance (ASV) benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants